Dave Ferguson's Blog: ColdFusion.getElementValue returns wrong value: Part 2

ColdFusion.getElementValue returns wrong value: Part 2

Oct 17

posted by Dave in ColdFusion 8 | 9 Comments

I spent a few hours this morning working on some code that would duplicate this issue. I have been able to determine that the problem only occurs when using ColdFusion.Window.create. Using the cfwindow tag does not produce this issue.

The code below will duplicate the issue. The first part is the script for creating a window. This code creates a new window and destroys the previous. This is because refreshOnShow:true has no effect and my window loads dynamic content. The 2nd part of the code is the window content. This has a function to get the value of the form field in the window.

On first load everything is fine. However, once you close the window and open it up again the alerted value is now a list of values.

view plain print about

1<CFAJAXIMPORT TAGS="cfwindow">
2
3<SCRIPT>
4winCounter = 1;
5winName = "window"+winCounter;
6
7function loadWindow(){
8    winH = 400;
9    winW = 300;
10
11    try{
12        ColdFusion.Window.getWindowObject(winName).destroy();
13    } catch (err) {}
14
15    winName = "window"+winCounter;
16    winCounter = winCounter+1;
17    ColdFusion.Window.create(winName, 'test window', 'test.cfm', {refreshOnShow:true,height:winH,width:winW,modal:true,closable:true, draggable:false,resizable:false,center:true,initshow:true});
18}
19
20</SCRIPT>
21<A HREF="JAVASCRIPT: loadWindow();">LOAD WINDOW</A>

window content file test.cfm

view plain print about

1<FORM method="post" action="./test.cfm">
2 <input type="text" name="testField" id="testField" value="123" />
3</FORM>
4
5<A HREF="JAVASCRIPT: alert(ColdFusion.getElementValue('testField'));">SHOW VALUE</A>

There ya have it. Hopefully this can be addressed and fixed in future versions of CF.

--Dave

This entry was posted on October 17, 2007 at 8:38 AM and has received 2090 views. There are currently 9 comments. Print this entry.

Related Blog Entries

ColdFusion.getElementValue returns wrong value (September 13, 2007)

TweetBacks

Comments

[Add Comment] [Subscribe to Comments]

#1 by Brandon Wittwer on 10/17/07 - 7:06 AM

So the other day when I ran into this issue, I did some digging and found the onHide function. Which gave me an idea. I register the name of the window as a random name... to allow multiple instances to be controlled seperately. But the important part is the "onHide" event. I register that event to fire off a destruct function which gets hold of the innerHTML of the window that is closing and overwrites it with an empty string.

I'm not sure of your blog's comment ability.. so hopefully this looks right

[CODE]
var thelastwindow;
var editWindow = function editWindow(recordType){
         var name = 'main'+Math.random()
         var title = 'Create Org';
         var width = 700;
         var myurl='oogabooga.cfm'
         var height = 700;
         centered = true;
   //options available{height:500,width:500,modal:true,closable:true, draggable:false,resizable:false,center:true,initshow:true}
         var config = new Object();
         config.width = width;
         config.height = height;
         config.centered = centered;
         ColdFusion.Window.create(name, title,myurl,config);
         ColdFusion.Window.onHide(name, windowClose);
      }
var windowClose = function(name){
         ColdFusion.Window.getWindowObject(name).body.dom.innerHTML = "";
         thelastwindow = name;
          }
[/CODE]
The onHide event passes the window name it fired from. and the body of a cfwindow has a dom elemental structure, so that gets access to the innerHTML property of the window and *poof*, all the extra copies of the form that are laying around in lala land disappear and you are left with 1 value per opened and closed window.

That very last bit about thelastwindow could be used to make sure any references to that window were also taken care of. it just drops the last deleted window into a global var for whatever you might need it for.
#2 by todd sharp on 10/17/07 - 7:40 AM

I'd just call a ColdFusion.navigate('windowurl.cfm', 'winName') to refresh the contents after you create it. It is the same effect as refreshOnShow really...
#3 by Brandon Wittwer on 10/17/07 - 7:47 AM

Adding a ColdFusion.navigate doesnt fix anything. you should test ideas before suggesting them.
#4 by Dave Ferguson on 10/17/07 - 7:55 AM

@Todd... I tried your idea. I added this to the script that creates the window..

if (winCounter != 1){
      ColdFusion.navigate('test.cfm', winName);
      ColdFusion.Window.show(winName);
      return;
   }

This actually worked. However, in the project I am working on this workaround it is not feasible. The demo code I posted is a subset of a much larger set of code for an interface. In this interface multiple windows are opened with varying sizes and content. I have to rebuild the window on every show so I can resize it and reload its content. Even with the destroy function the window is not completely destroyed thus my problem.

--Dave
#5 by Brandon Wittwer on 10/17/07 - 8:10 AM

Dave - does my suggestion not work? using the onHide event to wipe the form from the dom works for me in my. You could call the destroy function in the onhide event as well to completely eliminate the window itself.

Side note: does your formid change between windows that are interfering with eachother? I was testing the idea of opening multiple of the same form with different form ID's and it doesn't seem to pick up the correct form. i can upload examples if u like.
#6 by Brandon Wittwer on 10/17/07 - 8:12 AM

@todd - The way I implemented your code didnt fix anything. (create with initshow:true, then the navigate) But initShow:false and showing after the navigate function does seem to work.
#7 by Dave Ferguson on 10/17/07 - 8:19 AM

@Brandon - I put in the close function as you suggested and it did correct the issue.

Thanks,

--Dave
#8 by todd sharp on 10/17/07 - 8:21 AM

You can 'create' the window every time the function is called - and refresh the contents with CF.navigate() each time - you should also be able to tap into the underlying Ext.BasicDialog element to resize/relocate, etc as needed.

I see no reason why what you're trying to can't be done Dave - I'm a bit confused still I think but it should all work out for you.

To clarify things - CF.getElementValue() is not returning the wrong value - you were just adding that field to the DOM every time you showed the window so it returned the list of values.
#9 by Brandon Wittwer on 10/17/07 - 9:41 AM

Oh, I see what you're doing, Todd. You're suggesting recycling the same named window throughout different requests and models. So when its closed, its not really destroyed...its just opened again with a different function. While that works for simple applications, on more MDI type apps it would require a very delicate dance of initializing and recycling windows. While that would probably be more efficient, its also overhead on the developer that might not be deserved in a 1.0 application. Maybe as a revision... which as we all know... revisions are the stuff of repeat business. :) (if your a consultant that is)

[Add Comment] [Subscribe to Comments]

Dave Ferguson's Blog

ColdFusion.getElementValue returns wrong value: Part 2

TweetBacks

Comments

Links

Subscribe

Recent Comments

Recent Entries

Archives by Subject